[bot] Merge master/9f97835f into rel/dev - #1756
Conversation
Mid-stream disconnects ("peer closed connection without sending
complete message body") were not retried at all -- _is_retryable_exc
only handled TransientChatError and HTTPStatusError. Confirmed live:
this contaminated ~1-4% of visualization runs with a hard fail on pure
network flake, indistinguishable from a real agent/content failure in
the result.
…t time parse_sse_lines wrapped every next(it) failure in the non-retryable ChatError, including httpx.RemoteProtocolError -- so _is_retryable_exc's RemoteProtocolError branch only ever fired for a disconnect at connect time, never for the mid-stream case CodeRabbit flagged and the one actually seen in production. Raise TransientChatError instead when the wrapped exception is a RemoteProtocolError.
Fix: retry httpx.RemoteProtocolError in the SSE chat client
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1756 +/- ##
========================================
Coverage 80.58% 80.59%
========================================
Files 272 272
Lines 19218 19223 +5
========================================
+ Hits 15487 15492 +5
Misses 3731 3731 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🚀 Automated PR to perform merge from master into rel/dev with changes up to 9f97835 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/32703694087).