plumb max_guest_log_level through MultiUseSandbox::from_snapshot - #1699
Open
sethryanrollins wants to merge 1 commit into
Open
plumb max_guest_log_level through MultiUseSandbox::from_snapshot#1699sethryanrollins wants to merge 1 commit into
max_guest_log_level through MultiUseSandbox::from_snapshot#1699sethryanrollins wants to merge 1 commit into
Conversation
jsturtevant
reviewed
Jul 31, 2026
sethryanrollins
marked this pull request as ready for review
August 2, 2026 22:08
sethryanrollins
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
August 2, 2026 22:08
Contributor
|
this looks in the right direction, @sethryanrollins could you sign the DCO or fix the commits and rebase? then we can run CI |
jsturtevant
added
the
kind/enhancement
sethryanrollins
force-pushed
the
sethr/issue-1698
branch
from
August 8, 2026 01:37
9d573a1 to
a33ba7e
Compare
Plumb max_guest_log_level through MultiUseSandbox::from_snapshot and add changelog entry Signed-off-by: Seth Rollins <sethryanrollins@gmail.com>
sethryanrollins
force-pushed
the
sethr/issue-1698
branch
from
August 8, 2026 01:46
a33ba7e to
be9db37
Compare
Contributor
|
thanks for your contribution and you interest in hyperlight @sethryanrollins! What I was hoping to do is to address the issue for regular snapshots (taken after init has ran), rather than for these pre-init snapshots (which are not public anyway). It looks like the current state of the PR only addresses pre-init snapshot. Would you be willing to rewrite the PR to deal with post-init snapshots instead? Please let me know if you have any questions as it probably won't be trivial! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft for #1698