fix(agent): resolve secrets_manager alongside identity_administration - #820
Open
roeezis wants to merge 3 commits into
Open
fix(agent): resolve secrets_manager alongside identity_administration#820roeezis wants to merge 3 commits into
roeezis wants to merge 3 commits into
Conversation
added 3 commits
August 23, 2026 13:48
Introduces a small, isolated interface for reading a JWT from a file path — the first piece of the upcoming Conjur JWT authentication path, split out on its own since nothing else in this PR depends on it yet.
identity.go mixed the shared client/token-cache plumbing with the CyberArk Identity username/password (UP) login flow. Move the UP-specific code into username_password.go so the shared plumbing stays easy to find once a second login mechanism (Conjur JWT) is added alongside it. No behavior change — pure extraction, plus unexporting ActionAnswer and exporting the mock's success credentials for other packages' tests.
The Service Discovery API returns several independently-hosted services; the authn-jwt exchange this PR series adds is served by secrets_manager, a different host from identity_administration. Add a SecretsManager field to Services and parse it, so callers have it available — nothing reads it yet, that lands in a later PR alongside the client that needs it.
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of the SMS/Conjur JWT authentication series (split out of #817). Stacked on #818, #819 — diff will shrink once those merge.
The Service Discovery API returns several independently-hosted services; the authn-jwt exchange this series adds is served by
secrets_manager, a different host fromidentity_administration. Adds aSecretsManagerfield toServicesand parses it, so callers have it available — nothing reads it yet, that lands in a later PR alongside the client that needs it.Test plan
go build ./...go test ./internal/cyberark/servicediscovery/... ./internal/envelope/...