[WIP] Draft of generalized RustBCA python wrapper(s) - #324
Merged
Conversation
…his is probable the model going forward, and it probably needs its own issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes #277
Description
This PR adds a new way to run RustBCA - a Python wrapper that takes an input-file-shaped dictionary and runs RustBCA without generating or parsing an input file.
This comes in two flavors:
rustbca_py(input_file, geometry_mode)which produces identical output files to the standalone code andrustbca_local_py(input_file, geometry_mode)which produces a dict from this Rust struct:All of this is made possible with the newest version of PyO3 and the
pythonizecrate, which allows one to serialize/deserialize python dicts to structs that implement serde (de)serialization.Tests
I've added tests that compare the output of the two new functions to the standalone code to
make_input_file_and_run.py.Todo