mirror: retry the completeness gate's GETs, and report the status it saw - #505
Closed
Sunrisepeak wants to merge 1 commit into
Closed
mirror: retry the completeness gate's GETs, and report the status it saw#505Sunrisepeak wants to merge 1 commit into
Sunrisepeak wants to merge 1 commit into
Conversation
The v2026.8.25.1 release failed its completeness gate twice. Both runs
reported all 16 assets "already mirrored, skipping", and the gate then
failed on one of them:
[mirror] FAIL: missing/unverified:
https://gitcode.com/xlings-res/mcpp/.../linux-x86_64.tar.gz
502ERR https://gitcode.com/.../linux-x86_64.tar.gz
Fetched by hand a minute later it was 5,772,395 bytes whose sha256 matched
the published checksum exactly. The file was never missing; GitCode's edge
answered 502 once, and a single unretried GET decided the release.
Both verification GETs now retry with `--retry-all-errors` — not plain
`--retry`, which covers transient HTTP codes but not the transport-layer
failures this path also sees; that distinction has cost this repository a
run of red CI before.
Also fixes the status the log reports. `|| echo ERR` APPENDS: `-f` makes
curl exit non-zero on a 502 while `-w` has already written the code, so the
variable read `502ERR` and no one could grep the log for a status. ERR is
now substituted only when curl printed nothing at all.
Member
Author
|
Folded into #506 — the goal is one PR carrying the whole family. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2026.8.25.1 release failed twice on a single transient 502 from GitCode for an asset it had already mirrored — verified by hand as 5,772,395 bytes with the published sha256.
--retry-all-errors(plain--retrydoes not cover the transport-layer failures this path sees)|| echo ERRappended rather than replaced, so a 502 was logged as502ERRand the log could not be grepped for a statusPure CI-tooling change; no effect on the build.