Browser commenting polish - #329072
Draft
kycutler wants to merge 1 commit into
Draft
Conversation
kycutler
force-pushed
the
kycutler/commentingpolish
branch
from
August 5, 2026 00:16
ac5154e to
2c1af98
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes Integrated Browser element commenting interactions and screenshot capture.
Changes:
- Refines comment pins, previews, animations, focus, and dismissal behavior.
- Prevents comment-input keyboard events reaching the page.
- Adds paint synchronization and smoke-test coverage.
Show a summary per file
| File | Description |
|---|---|
preload-browserView.ts |
Reworks commenting UI and interactions. |
browserEditorChatFeatures.ts |
Waits for repaint before element screenshots. |
browserView.test.ts |
Tests keyboard-event isolation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Balanced
| ref: new WeakRef(findCommonVisibleAncestor(els) ?? target), | ||
| anchor: { x: event.clientX, y: event.clientY } | ||
| }; | ||
| if (event.button === 2) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #328690
Closes #328795
Closes #328793
Closes #328792