Revert "Reduce floating panel margins for layout consistency" - #329141
Open
mrleemurray wants to merge 5 commits into
Open
Revert "Reduce floating panel margins for layout consistency"#329141mrleemurray wants to merge 5 commits into
mrleemurray wants to merge 5 commits into
Conversation
This reverts commit 7bbbeaa.
Giuspepe
previously approved these changes
Aug 5, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @benibenjMatched files:
|
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The revert consistently restores the previous geometry; only minor documentation corrections remain.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Restores the 6px floating-panel spacing to reduce visual noise.
Changes:
- Restores 2px trailing margins and matching sash geometry.
- Restores the TypeScript layout inset.
- Removes the reverted 4px-gap test.
File summaries
| File | Description |
|---|---|
floatingPanels.css |
Restores panel spacing and sash geometry. |
layoutService.ts |
Restores the 2px inner margin. |
layoutService.test.ts |
Removes the reverted spacing assertion. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
benibenj
approved these changes
Aug 5, 2026
benibenj
previously approved these changes
Aug 5, 2026
DonJayamanne
previously approved these changes
Aug 5, 2026
roblourens
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #328963 - the reduced spacing adds to the visual noise.