Add failing test: duplicate typename__ when type implements multiple interfaces - #442
Open
magicmark wants to merge 1 commit into
Open
Add failing test: duplicate typename__ when type implements multiple interfaces#442magicmark wants to merge 1 commit into
magicmark wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
magicmark
force-pushed
the
fix/duplicate-typename-fields
branch
from
July 7, 2026 21:00
89ac6cc to
8c93608
Compare
When a concrete type implements multiple interfaces and a query uses inline fragments on those interfaces (each selecting __typename), the codegen produces duplicate typename__ fields in the generated Pydantic model. This causes mypy to fail with: Name "typename__" already defined [no-redef] Co-Authored-By: Claude <noreply@anthropic.com>
magicmark
force-pushed
the
fix/duplicate-typename-fields
branch
from
July 7, 2026 21:46
8c93608 to
22e36c5
Compare
magicmark
marked this pull request as ready for review
July 7, 2026 22:51
Author
|
@mirumee any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a concrete type implements multiple interfaces and a query spreads on both with
__typename, codegen emits the field twice — which makes mypy blow up withName "typename__" already defined [no-redef].Actual:
Expected:
Works fine at runtime (pydantic is happy), but mypy won't accept it.
Fix is at magicmark#1 (on my fork for now — can't target a fork branch as base on upstream).