refactor(ui): isolate file presentation state - #656
Open
benvinegar wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryRefactors file-presentation behavior without changing its external contract.
Confidence Score: 5/5The PR appears safe to merge, with the extracted hooks preserving the previous file-presentation behavior and adding focused coverage. The controller and rendering logic remain behaviorally aligned with their former inline implementations, and the type relocation uses type-only imports without introducing runtime module dependencies. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
App[App] --> Controller[useFilePresentationController]
App --> Rendering[useFilePresentationRendering]
Controller --> Selection[Selection and availability state]
Controller --> Controls[Menus, bulk actions, extension controls]
Rendering --> Layouts[useFileViewLayouts]
Rendering --> Warnings[Bounded row-failure warnings]
Layouts --> DiffPane[DiffPane]
Warnings --> DiffPane
DiffPane --> DiffSection[DiffSection]
DiffSection --> FileView[FileView]
Reviews (1): Last reviewed commit: "refactor(ui): isolate file presentation ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useFilePresentationControlleruseFilePresentationRenderingValidation
bun run typecheckbun run format:checkbun run lintbun run test(1,757 pass, 9 skip)bun run test:integration(85 pass, 1 skip)bun run test:tty-smoke(9 pass)This PR description was generated by Pi using OpenAI GPT-5.3 Codex