fs: cancel in-flight stat on abort - #63142
Conversation
4425502 to
e4d317e
Compare
|
Drive-by: this looks like it's still not actually canceling the underlying call, which would involve invoking |
e4d317e to
8149c79
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63142 +/- ##
==========================================
- Coverage 90.21% 90.16% -0.05%
==========================================
Files 751 751
Lines 253550 253557 +7
Branches 47813 47772 -41
==========================================
- Hits 228733 228623 -110
- Misses 16076 16193 +117
Partials 8741 8741
🚀 New features to boost your workflow:
|
fc73958 to
6d3d629
Compare
|
Thanks for review @bakkot I added a new binding function for cancel |
|
cc @nodejs/fs |
|
@Renegade334, could you review this pr? |
6d3d629 to
4913c16
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I measuring uv_cancel. |
|
@mertcanaltin Merge commits don't work with Node.js tooling. Can you please rebase? |
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
4eb1ce8 to
2d21670
Compare
|
Thanks @trivikr, I've rebased now and measured. UV_THREADPOOL_SIZE=1, pool blocked by a pbkdf2 job, all 10,000 stadiums that were aborted while the pool was clogged are actually cancelled.
|
|
Update: The AbortError behavior was landed in main with #63143, leaving only the uv_cancel call that actually dropped the request from the threadpool queue in this PR. |
The AbortError behavior was landed in main with #63143, leaving only the uv_cancel call that actually dropped the request from the threadpool queue in this PR.