stream: drain pending writes before broadcast end - #65334
Merged
trivikr merged 1 commit intoAug 23, 2026
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65334 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 751 751
Lines 252709 252767 +58
Branches 47557 47588 +31
=======================================
+ Hits 227800 227861 +61
+ Misses 16206 16202 -4
- Partials 8703 8704 +1
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 17, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Keep processing writes that were queued before end(). Signal the broadcast end only after those writes enter the shared buffer. Resolve end() after all consumers reach end-of-stream. This prevents backpressured writes from remaining pending forever. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: nodejs#65334 Fixes: nodejs#65333 Reviewed-By: James M Snell <jasnell@gmail.com>
trivikr
force-pushed
the
stream-iter-bc-end-stranding-writes-2
branch
from
August 23, 2026 20:26
7e864ea to
c28857e
Compare
Member
Author
|
Landed in c28857e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65333
Keep processing writes that were queued before end(). Signal the broadcast end only after those writes enter the shared buffer.
Resolve end() after all consumers reach end-of-stream. This prevents backpressured writes from remaining pending forever.
Assisted-by: codex:gpt-5.6-sol