Skip to content

doc: clarify security triage dispositions and permission boundaries - #65436

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:security-triage-permission-boundaries
Open

doc: clarify security triage dispositions and permission boundaries#65436
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:security-triage-permission-boundaries

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

Clarify SECURITY.md by defining security triage dispositions, documenting same-process self-harm exclusions, and separating Permission Model reports into vulnerability, security-interest, and excluded cases. Also correct the worker_threads guidance: workers with modified execArgv or env may not inherit the parent permission configuration, while worker creation itself remains gated by --allow-worker.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 20, 2026
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 20, 2026
Comment thread SECURITY.md Outdated
Comment on lines +159 to +162
* **Vulnerability**: Reachable through an element Node.js does not trust and
causes disclosure or loss of integrity or confidentiality of protected data,
arbitrary code execution, or runtime unavailability under the DoS criteria
described below.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might just be me, but I find this line slightly hard to follow as it's written. I think the wording is easy to overlap with vulnerabilities that we reject due to requiring untrusted input.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a suggestion?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this? But non-blocking if others prefer the original version:

Suggested change
* **Vulnerability**: Reachable through an element Node.js does not trust and
causes disclosure or loss of integrity or confidentiality of protected data,
arbitrary code execution, or runtime unavailability under the DoS criteria
described below.
* **Vulnerability**: A Node.js defect that an untrusted party can exploit to
disclose protected data, compromise its integrity or confidentiality, execute
arbitrary code, or make the runtime unavailable under the DoS criteria below.

@RafaelGSS RafaelGSS Aug 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m just confused with what “protected data” means here. Someone could reasonably interpret “protected” as protected by application authorization, filesystem permissions, the Permission Model, or something else outside Node’s threat model

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just kept that term as it was in the original

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main confusion was with this part:

Vulnerability: Reachable through an element Node.js does not trust

But, perhaps need to rethink the whole line.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread SECURITY.md Outdated
@RafaelGSS
RafaelGSS force-pushed the security-triage-permission-boundaries branch from 62bdb7d to 470829e Compare August 25, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants