Skip to content

fix: accept any warn-capable logger in env validation - #883

Merged
harlan-zw merged 1 commit into
mainfrom
fix/nuxt-logger-types
Aug 24, 2026
Merged

fix: accept any warn-capable logger in env validation#883
harlan-zw merged 1 commit into
mainfrom
fix/nuxt-logger-types

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

I have a better fix coming in (self-contained nuxt/kit types for the logger) but for now this should unbreak ecosystem-ci

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scripts-playground Ready Ready Preview Aug 24, 2026 9:00am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c657e433-adcc-49bb-8238-37751fc4bcf2

📥 Commits

Reviewing files that changed from the base of the PR and between 5052a9f and 71718b3.

📒 Files selected for processing (2)
  • packages/script/src/validate-env.ts
  • test/unit/validate-env.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

validateScriptsEnvVars now accepts the local WarnLogger interface instead of ConsolaInstance. The interface requires only warn(message: string). The unit test logger factory now relies on inferred typing and no longer imports or casts to ConsolaInstance.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 71718

This is a localized change to accept warn-capable loggers during environment validation; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: environment validation now accepts any logger with a warn method.
Description check ✅ Passed The description explains that the logger change is an interim fix to unblock ecosystem CI.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nuxt-logger-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts@883

commit: 71718b3

@github-actions

Copy link
Copy Markdown

📦 Package Size

No notable size changes

📚 22 runtime dependencies (no change)

All tracked output (27)
Package output Gzipped Raw
@nuxt/scripts-cli · runtime dependencies 72 kB 355 kB
@nuxt/scripts-cli · dependency magicast 72 kB 355 kB
@nuxt/scripts-cli · export . 3.4 kB 12 kB
@nuxt/scripts-cli · published payload 3.4 kB 12 kB
@nuxt/scripts · runtime dependencies 451 kB 2.00 MB
@nuxt/scripts · dependency @nuxt/devtools-kit 2.9 kB 7.7 kB
@nuxt/scripts · dependency @oxc-project/types 0 B 0 B
@nuxt/scripts · dependency @vueuse/core 174 kB 707 kB
@nuxt/scripts · dependency @vueuse/shared 39 kB 154 kB
@nuxt/scripts · dependency h3 34 kB 146 kB
@nuxt/scripts · dependency magic-string 9.4 kB 42 kB
@nuxt/scripts · dependency oxc-walker 7.6 kB 31 kB
@nuxt/scripts · dependency semver 25 kB 72 kB
@nuxt/scripts · dependency sirv 8.8 kB 21 kB
@nuxt/scripts · dependency unstorage 70 kB 225 kB
@nuxt/scripts · dependency valibot 80 kB 592 kB
@nuxt/scripts · dist/runtime 98 kB 284 kB
@nuxt/scripts · export . 25 kB 106 kB
@nuxt/scripts · export ./registry 28 kB 89 kB
@nuxt/scripts · export ./stats 13 kB 89 kB
@nuxt/scripts · export ./types-source 43 kB 222 kB
@nuxt/scripts · published payload 208 kB 791 kB
@nuxt/scripts · components runtime 2.4 kB 6.2 kB
@nuxt/scripts · composables runtime 7.5 kB 24 kB
@nuxt/scripts · registry runtime 42 kB 123 kB
@nuxt/scripts · server runtime 28 kB 84 kB
@nuxt/scripts · utils runtime 2.5 kB 7.4 kB
Runtime dependencies (22)
Package Dependency Requested Resolved Cost
@nuxt/scripts-cli magicast ^0.5.4 0.5.4 📦 72 kB gzip
@nuxt/scripts-cli pathe ^2.0.3 2.0.3 ♻️ free via Nuxt 4.5.1
@nuxt/scripts @nuxt/devtools-kit ^3.4.1 3.4.1 📦 2.9 kB gzip
@nuxt/scripts @oxc-project/types ^0.143.0 0.143.0 📦 0 B gzip
@nuxt/scripts @vueuse/core ^14.4.0 14.4.0 📦 174 kB gzip
@nuxt/scripts @vueuse/shared ^14.4.0 14.4.0 📦 39 kB gzip
@nuxt/scripts consola ^3.4.2 3.4.2 ♻️ free via Nuxt 4.5.1
@nuxt/scripts defu ^6.1.7 6.1.7 ♻️ free via Nuxt 4.5.1
@nuxt/scripts h3 ^1.15.11 1.15.11 📦 34 kB gzip
@nuxt/scripts magic-string ^1.1.0 1.1.0 📦 9.4 kB gzip, Nuxt has 1.0.0
@nuxt/scripts ofetch ^1.5.1 1.5.1 ♻️ free via Nuxt 4.5.1
@nuxt/scripts ohash ^2.0.11 2.0.11 ♻️ free via Nuxt 4.5.1
@nuxt/scripts oxc-walker ^1.1.1 1.1.1 📦 7.6 kB gzip, Nuxt has 1.0.0
@nuxt/scripts pathe ^2.0.3 2.0.3 ♻️ free via Nuxt 4.5.1
@nuxt/scripts semver ^7.8.5 7.8.5 📦 25 kB gzip
@nuxt/scripts sirv ^3.0.2 3.0.2 📦 8.8 kB gzip
@nuxt/scripts std-env ^4.2.0 4.2.0 ♻️ free via Nuxt 4.5.1
@nuxt/scripts ufo ^1.6.4 1.6.4 ♻️ free via Nuxt 4.5.1
@nuxt/scripts ultrahtml ^1.7.0 1.7.0 ♻️ free via Nuxt 4.5.1
@nuxt/scripts unplugin ^3.3.0 3.3.0 ♻️ free via Nuxt 4.5.1
@nuxt/scripts unstorage ^1.17.5 1.17.5 📦 70 kB gzip
@nuxt/scripts valibot ^1.4.2 1.4.2 📦 80 kB gzip

Baseline: main_@_5052a9fd___2026-08-22 · gzip is the comparison metric · changes below 16 B gzip are ignored

@harlan-zw
harlan-zw merged commit 9368f01 into main Aug 24, 2026
16 checks passed
@harlan-zw
harlan-zw deleted the fix/nuxt-logger-types branch August 24, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants