Skip to content

Clicking on api endpoint tab before asserting the entity card #31039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohit0301 wants to merge 1 commit into from
Open

Clicking on api endpoint tab before asserting the entity card #31039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ Object.entries(entities).forEach(([key, EntityClass]) => {
page,
EntityDataClass.domain1.responseData,
entity.entityResponseData?.['fullyQualifiedName'] ??
entity.entityResponseData?.['name']
entity.entityResponseData?.['name'],
entity.exploreTabName
);

await visitServiceDetailsPage(
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/support/entity/ApiEndpointClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ export class ApiEndpointClass extends EntityClass {
this.serviceCategory = SERVICE_TYPE.ApiService;
this.serviceType = ServiceTypes.API_SERVICES;
this.type = 'ApiEndpoint';
this.exploreTabName = 'API Endpoints';
this.childrenTabId = 'schema';
this.childrenSelectorId = this.children[0].fullyQualifiedName ?? '';
}
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/support/entity/EntityClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@

export class EntityClass {
type = '';
exploreTabName?: string;
serviceCategory?: GlobalSettingOptions;
serviceType?: ServiceTypes;
childrenTabId?: string;
Expand All @@ -95,7 +96,7 @@
return {};
}

public set(_data: any) {

Check warning on line 99 in openmetadata-ui/src/main/resources/ui/playwright/support/entity/EntityClass.ts

View workflow job for this annotation

GitHub Actions / checkstyle 

Unexpected any. Specify a different type
// handle in parent component
}

Expand Down
8 changes: 7 additions & 1 deletion openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,8 @@ export const waitForSearchResult = async (
export const verifyDomainPropagation = async (
page: Page,
domain: Domain['responseData'],
childFqnSearchTerm: string
childFqnSearchTerm: string,
exploreTabName?: string
) => {
// Domain propagation from the parent service to its children — and the
// subsequent search reindex — is eventually consistent. Gate on the search
Expand Down Expand Up @@ -942,6 +943,11 @@ export const verifyDomainPropagation = async (
await searchBox.press('Enter');
await waitForAllLoadersToDisappear(page);

if (exploreTabName) {
await page.getByRole('menuitem', { name: exploreTabName }).click();
await waitForAllLoadersToDisappear(page);
}

const entityCard = page.getByTestId(`table-data-card_${childFqnSearchTerm}`);
await expect(entityCard).toBeVisible({ timeout: 30_000 });
await expect(entityCard).toContainText(domain.displayName);
Expand Down
Loading