Perform and cache journal visibility check in RequestStore - #24591
Open
oliverguenther wants to merge 1 commit into
Open
Perform and cache journal visibility check in RequestStore#24591oliverguenther wants to merge 1 commit into
oliverguenther wants to merge 1 commit into
Conversation
JournalFormatter::NamedAssociation resolved every association with a bare find_by and printed its name, so a journal could name a record from a project the reader has no access to. We replace these checks with a visible? check by default IF the association responds to it. These checks add more computational time, so we cache them in RequestStore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JournalFormatter::NamedAssociation resolved every association with a bare find_by and printed its name, so a journal could name a record from a project the reader has no access to.
We replace these checks with a visible? check by default IF the association responds to it.
These checks add more computational time, so we cache them in RequestStore.
Ticket
https://community.openproject.org/work_packages/OP-19853