feat: Add large command chunking - #306
Draft
camdecoster wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add handling of large commands such that we don't hit Chromium's 100MiB buffer size limit.
Closes #305.
Changes
Testing
plotly,kaleido==1.2.0,choreographer, and any other required dependencies. Kaleido 1.2.0 is required because 1.3.0 added chunking code and we want to test the Choreographer chunking code.uv pip install -e /path/to/choreographerNotes
Runtime.callFunctionOnflowchart TD A["send_command"] --> B["serialize once"] B --> C{"over 100MiB?"} C -->|no| D["write to pipe"] D --> R["response to caller"] C -->|yes| E{"Runtime.callFunctionOn<br/>with value arguments?"} E -->|no| F["raise MessageTooLargeError"] E -->|yes| G["push the serialized text into<br/>the page in 10MiB pieces"] G --> H["run a wrapper that rejoins them,<br/>pulls out the arguments, and<br/>applies the caller's function"] H --> R