Skip to content

fix: keep PR title check required after rebases - #2414

Merged
jaydeluca merged 1 commit into
prometheus:mainfrom
zeitlinger:fix/pr-title-check-rebases
Aug 24, 2026
Merged

fix: keep PR title check required after rebases#2414
jaydeluca merged 1 commit into
prometheus:mainfrom
zeitlinger:fix/pr-title-check-rebases

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • rerun the PR title check after PR branch updates and reopen events
  • give the title check a unique status context so it cannot be satisfied by the regular lint job

This closes the workflow gap observed on #2410, where Renovate rebased the branch, the failed title check remained attached to the previous SHA, and the successful regular lint job satisfied the required lint context.

After this PR merges, pr-title must be added as a distinct required check in the main-branch ruleset. Adding it before merge would block every existing PR because their merge commits still use the old lint job name.

Validation

  • mise run lint:fix
  • mise run lint
  • pr-title check passed on this PR with the new job name

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@jaydeluca
jaydeluca merged commit e3d4c3b into prometheus:main Aug 24, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants