Skip to content

Move Ruff config to pyproject.toml - #81

Merged
hugovk merged 4 commits into
python:mainfrom
hugovk:ruff
Aug 25, 2026
Merged

Move Ruff config to pyproject.toml#81
hugovk merged 4 commits into
python:mainfrom
hugovk:ruff

Conversation

@hugovk

@hugovk hugovk commented Jul 24, 2026

Copy link
Copy Markdown
Member

It makes it easier to diff other projects when the config is centralised in the usual place.

Also update pre-commit hooks and change maintainers' name from "Python Core Developers" to "Python Core Team".

Comment thread .ruff.toml
@@ -1,16 +0,0 @@
target-version = "py310"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed in pyproject.toml because Ruff will get it from requires-python = ">=3.10".

https://docs.astral.sh/ruff/configuration/#inferring-the-python-version

Comment thread pyproject.toml
[tool.ruff]
fix = true
format.preview = true
format.quote-style = "single"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on dropping this and using the default double?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest dropping this altogether, I don't think consistent quotes are important enough for the linter to annoy us about them.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted!

Comment thread pyproject.toml
readme = "README.md"
maintainers = [
{ name = "Python Core Developers", email = "core-workflow@mail.python.org" },
{ name = "Python Core Team", email = "core-workflow@mail.python.org" },

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that email probably won't work any more. But I don't think we have a better alternative?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed:

550 5.1.1 : Recipient address rejected: User unknown Contact your postmaster/admin for assistance.

Let's remove the email address (in another PR), it's not required.

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk merged commit c9b8225 into python:main Aug 25, 2026
12 checks passed
@hugovk
hugovk deleted the ruff branch August 25, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants