gh-155258: Make the curses.complexstr signature introspectable - #155259
Open
fedonman wants to merge 1 commit into
Open
gh-155258: Make the curses.complexstr signature introspectable#155259fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complexstr's two optional parameters were declaredobject = NULL, andNULLhas noPython repr, so Argument Clinic wrote
<unrepresentable>into the text signature andinspect.signature()raised.Declaring them
object(c_default="NULL") = Nonemakes the default representable andleaves the C default as
NULL, so "omitted" and "given" stay distinguishable:Behaviour does not change. The six constructor forms that pass or omit attr and pair,
with a string and with a sequence, give identical results before and after, including the
three that raise. 37 other stdlib parameters already use this declaration.
test_cursespasses underTERM=xterm-256colorandvt100. The new assertion failswithout the change, with the
ValueErrorabove.complexstris new in 3.16, so there is no NEWS entry.inspect.signature()fails on the newcurses.complexstrtype #155258