PEP 835: Refined rationale and ecosystem statistics - #5098
Open
till-varoquaux wants to merge 1 commit into
Open
Conversation
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
from
August 16, 2026 16:53
5760f61 to
0c2c78d
Compare
Documentation build overview
|
Contributor
Author
|
After this, I think we'll be done for a review by the typing council. |
ilevkivskyi
approved these changes
Aug 21, 2026
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, thanks! I have just one question to clarify.
| * **SQLAlchemy:** 280 LOCs | ||
| * **cattrs:** 153 LOCs | ||
| * **Hypothesis:** 13 LOCs | ||
| * **Beartype:** 10 LOCs |
Member
There was a problem hiding this comment.
Does these number include adding __rmatmul__ so that None @ <smth> will work?
Contributor
Author
There was a problem hiding this comment.
I've updated the PEP to include the __rmatmul__ cost in the totals. Adding the fallback requires exactly two lines of code per metadata base class:
def __rmatmul__(self, typ: Any) -> Any:
return Annotated[typ, self]Here is the exact breakdown of the added lines:
- Pydantic: +8 LOCs (added to 4 metadata classes)
- SQLAlchemy, Hypothesis, Beartype, cattrs: +2 LOCs each
- FastAPI: +0 LOCs (inherits from Pydantic)
The ecosystem totals in the PEP now fully reflect this. Thanks for catching this.
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
from
August 22, 2026 03:35
0c2c78d to
b1af947
Compare
- Move Format.TYPE to Rejected Ideas - Update formatting to '@ annot' throughout - Refine __rmatmul__ language to encourage it as a robust fallback - Integrate Annotated usage and migration stats
till-varoquaux
force-pushed
the
feature/pep-835-update
branch
from
August 22, 2026 04:11
b1af947 to
d7097ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates PEP 835 based on discourse feedback, adding metrics from the ecosystem migration.