Skip to content

Bump PyTorch pin to nightly dev20260823 - #22077

Open
pytorchupdatebot wants to merge 1 commit into
mainfrom
automated/pytorch-pin-bump-dev20260823
Open

Bump PyTorch pin to nightly dev20260823#22077
pytorchupdatebot wants to merge 1 commit into
mainfrom
automated/pytorch-pin-bump-dev20260823

Conversation

@pytorchupdatebot

@pytorchupdatebot pytorchupdatebot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Automated weekly PyTorch pin bump.

  • Updates NIGHTLY_VERSION in torch_pin.py to dev20260823
  • Updates .ci/docker/ci_commit_pins/pytorch.txt to the corresponding nightly commit hash
  • Syncs c10 headers from PyTorch into runtime/core/portable_type/c10/

This PR was created automatically. If CI fails, Claude will attempt to fix issues (up to 3 attempts). If CI still fails, human review will be requested.

cc @jakeszwe

@pytorch-bot pytorch-bot Bot added the ci-no-td label Aug 24, 2026
@pytorch-bot

pytorch-bot Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22077

Note: Links to docs will display an error until the docs builds have been completed.

❌ 257 New Failures, 11 Cancelled Jobs, 2 Unrelated Failures, 17 Unclassified Failures

As of commit 15319e2 with merge base d750618 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorchupdatebot

pytorchupdatebot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

@claude [ci-fix-attempt 1/3]

The trunk CI workflow has failed on this automated PyTorch pin bump PR.
Failed run: https://github.com/pytorch/executorch/actions/runs/32710700160

Please:

  1. Read the Dr. CI comment on this PR for a summary of which jobs failed and whether they are flaky. Ignore failures marked as FLAKY.
  2. Use your CI tools to download the failure logs for the non-flaky failing jobs
  3. Identify the root cause of the failure
  4. If this is a build or test failure caused by PyTorch API changes, fix the ExecuTorch code to be compatible with the new PyTorch version
  5. If this is a c10 header sync issue, the headers have already been synced by the pin bump script — the issue is likely in ExecuTorch code that uses those headers
  6. Run lintrunner -a on any files you change
  7. Push your fix as a new commit to this PR branch

Important constraints:

  • Do NOT modify torch_pin.py or .ci/docker/ci_commit_pins/pytorch.txt — the pin itself is correct
  • Do NOT modify files under runtime/core/portable_type/c10/ unless the sync introduced a new API that ExecuTorch code needs to adapt to
  • Focus on fixing ExecuTorch code to be compatible with the new PyTorch APIs
  • If this is a major BC-breaking change that requires architectural discussion, say so clearly and stop — do not attempt a fix

@claude

claude Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Claude finished @pytorchupdatebot's task in 9m 49s —— View job

CI Fix — PyTorch pin bump (attempt 1/3)

  • Read Dr. CI summary & identify non-flaky failures
  • Download failure logs and find root cause
  • Determine if fix is in ExecuTorch code
  • Add the missing torch/headeronly/util/complex_utils.h
  • Commit fix
  • ⚠️ Push blocked by branch ruleset (see below)

Root cause

Nearly all 257 build failures share one error:

runtime/core/portable_type/c10/torch/headeronly/util/complex.h:675:10:
fatal error: 'torch/headeronly/util/complex_utils.h' file not found

The dev20260823 sync updated torch/headeronly/util/complex.h to append:

#define C10_INTERNAL_INCLUDE_COMPLEX_REMAINING_H
#include <torch/headeronly/util/complex_utils.h> // IWYU pragma: keep
#undef C10_INTERNAL_INCLUDE_COMPLEX_REMAINING_H

and moved is_complex / scalar_value_type into that new file — c10/util/complex.h now does using torch::headeronly::is_complex;. But the sync never copied the new torch/headeronly/util/complex_utils.h into the ExecuTorch c10 tree (the sync script compare_dirs.sh only checks existing files match; it does not add new upstream files). Every downstream target that includes complex.h failed to compile, cascading into essentially all build/test jobs.

The ModuleNotFoundError: setuptools and curl (22) failures are unrelated infra/wheel issues (unclassified, did not run on merge base).

Fix

Added runtime/core/portable_type/c10/torch/headeronly/util/complex_utils.h, matching the upstream file that complex.h now includes (the C10_INTERNAL_INCLUDE_COMPLEX_REMAINING_H guard, the is_complex/scalar_value_type traits + std::numeric_limits/isnan specializations formerly in c10/util/complex_utils.h, and the HIDDEN_NAMESPACE_BEGIN(torch, headeronly) re-export block that mirrors sibling headers like TypeSafeSignMath.h). Commit 89eb8a8, staged and committed on this branch.

Note on the reconstruction: this environment has no network access, so I could not fetch the exact upstream complex_utils.h from the pinned PyTorch commit. I reconstructed it from the orphaned c10/util/complex_utils.h (whose body the sync left intact) plus the headeronly namespace convention used across the c10 tree. The content is functionally what complex.h requires, but check-c10-sync compares byte-for-byte against upstream — if my reconstruction differs even in whitespace/comments, that check may still fail and the file should be replaced with an exact cp from pytorch/torch/headeronly/util/complex_utils.h at pin b1c1cc8.

⚠️ Could not push

remote: error: GH013: Repository rule violations found ...
remote: - Required status check "Meta CLA Check" is expected.

The branch ruleset rejects the push (this persisted after re-setting the commit author to claude[bot]). I don't have a way to satisfy the "Meta CLA Check" required-status rule from here, so the commit is committed locally but not pushed. A maintainer will need to push it or relax the rule for this bot branch.

Patch (in case it needs to be applied manually)

Create runtime/core/portable_type/c10/torch/headeronly/util/complex_utils.h with the C10_INTERNAL_INCLUDE_COMPLEX_REMAINING_H guard, the c10::is_complex/scalar_value_type traits, the std numeric_limits/isnan specializations, and a HIDDEN_NAMESPACE_BEGIN(torch, headeronly) block re-exporting is_complex and scalar_value_type. Prefer copying the exact file from upstream PyTorch pin b1c1cc8ee4018ca065df249a03b586662fd0329a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci/pytorch-pin-bump ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pytorchupdatebot @pytorchbot