Skip to content

SDPA: use exp_u20 for the softmax exponential (#22082) #22082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pssrawat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SDPA: use exp_u20 for the softmax exponential (#22082) #22082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions extension/llm/custom_ops/op_sdpa_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,9 +443,7 @@ _exp_reduce_sum_fusion_kernel(T1* a, const int& size, T2* out, T1& val) {
for (int i = 0; i < vec_size * (size / vec_size); i += vec_size) {
auto tmp0 = vec::VectorizedN<T1, 2>::loadu(a + i);
auto tmp1 = tmp0 - vec_max;
// Replace with exp_u20 later
// auto tmp2 = tmp1.exp_u20();
auto tmp2 = tmp1.exp();
auto tmp2 = tmp1.exp_u20();
vec_tmp_sum = vec_tmp_sum + tmp2;
tmp2.store(out + i);
}
Expand Down
Loading