Skip to content

[executorch] Update VGF test for fused ReLU qparams - #22088

Open
JacobSzwejbka wants to merge 1 commit into
mainfrom
update-vgf-fused-relu-qparams-test
Open

[executorch] Update VGF test for fused ReLU qparams#22088
JacobSzwejbka wants to merge 1 commit into
mainfrom
update-vgf-fused-relu-qparams-test

Conversation

@JacobSzwejbka

@JacobSzwejbka JacobSzwejbka commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Update the VGF rewrite-convolution regression for the ReLU fusion behavior introduced by D116922192.

The ReLU is fused into the convolution before ConvertToClampPass runs, so the clamp is fused away and no clamp node remains. Verify that the fused convolution owns the output quantization parameters with qmin rewritten to the zero point.

Rename the adjacent lowering test to describe the fused Conv-ReLU-Cat path.

Test plan:

  • buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_fold_and_annotate_q_params_vgf_quant_tracks_fused_relu_qparams"
  • buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_handles_fused_conv_relu_cat_branch" "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_infers_quantized_bias_dtype_from_inputs"
  • arc lint -a and arc lint on changed files
  • python -m py_compile backends/arm/test/passes/test_rewrite_conv_pass.py

This PR was authored with Codex.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22088

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6e73ffe with merge base 9a2d135 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 24, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant