[executorch] Update VGF test for fused ReLU qparams - #22088
Open
JacobSzwejbka wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22088
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e73ffe with merge base 9a2d135 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the VGF rewrite-convolution regression for the ReLU fusion behavior introduced by D116922192.
The ReLU is fused into the convolution before ConvertToClampPass runs, so the clamp is fused away and no clamp node remains. Verify that the fused convolution owns the output quantization parameters with qmin rewritten to the zero point.
Rename the adjacent lowering test to describe the fused Conv-ReLU-Cat path.
Test plan:
buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_fold_and_annotate_q_params_vgf_quant_tracks_fused_relu_qparams"buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_handles_fused_conv_relu_cat_branch" "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_infers_quantized_bias_dtype_from_inputs"arc lint -aandarc linton changed filespython -m py_compile backends/arm/test/passes/test_rewrite_conv_pass.pyThis PR was authored with Codex.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani