[LLM] Report skipped quantization layers and enable 8da8w - #22092
Open
JacobSzwejbka wants to merge 2 commits into
Open
[LLM] Report skipped quantization layers and enable 8da8w#22092JacobSzwejbka wants to merge 2 commits into
JacobSzwejbka wants to merge 2 commits into
Conversation
JacobSzwejbka
requested review from
larryliu0820 and
mergennachin
as code owners
August 24, 2026 17:38
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22092
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fecee84 with merge base 9a2d135 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
digantdesai
reviewed
Aug 24, 2026
| output = exported.module()(*inputs) | ||
|
|
||
| self.assertEqual(output.shape, (2, 16)) | ||
| self.assertTrue(torch.isfinite(output).all()) |
Contributor
There was a problem hiding this comment.
Nit: check against eager?
digantdesai
reviewed
Aug 24, 2026
| if verbose: | ||
| print("quantized model:", model) | ||
| return model | ||
| elif qmode in ("8da4w", "8da8w"): |
Contributor
There was a problem hiding this comment.
I guess this was already wired and working OK with XNNPACK?
digantdesai
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22044
Test plan
python -m pytest examples/models/llama/config/test_llm_config.py -qpython -m pytest examples/models/llama/source_transformation/test_quantize.py -qtorch.export.export