ci: re-enable pytest, splitting offline tests from live ones - #2861
Open
dokson wants to merge 1 commit into
Open
ci: re-enable pytest, splitting offline tests from live ones#2861dokson wants to merge 1 commit into
dokson wants to merge 1 commit into
Conversation
The pytest workflow was disabled because almost every test fetches from Yahoo and live fetches fail intermittently on CI IPs. But 60 of 211 tests are offline unit tests that never touch the network; conftest.py auto-marks the live ones `network`, so PRs run `pytest -m "not network"` while the live suite moves to a scheduled job. data.py also retries empty 2xx bodies (the throttling failure mode) under the existing `retries` config, enabled for tests in context.py.
dokson
force-pushed
the
ci/re-enable-pytest-split
branch
from
June 14, 2026 22:01
2fc4351 to
99d52df
Compare
Collaborator
|
Solved by #2849? |
Contributor
|
#2849 didn't solve it, just modified the disabled file to use uv and test multiple python versions. This PR will need to rebase and integrate into that workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pytest workflow was disabled because almost every test fetches from Yahoo and live fetches fail intermittently on CI IPs (
JSONDecodeErroron empty/throttled bodies). But 60 of 211 tests are offline unit tests that never touch the network —tests/conftest.pynow auto-marks the live onesnetwork, so PRs runpytest -m "not network"(fast, deterministic) while the live suite moves to a scheduled job.data.pyadditionally retries empty 2xx bodies (the throttling failure mode) under the existingretriesconfig, whichtests/context.pyenables for the test run.Closes #2261