Fix iOS crash when truncating composed text - #58101
Open
gooddev97 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #57499.
processTruncatedAttributedTextupdated color attributes whileNSLayoutManagerwas enumerating line fragments. When the truncation boundary landed inside a composed character sequence, TextKit attribute fixing could invalidate the glyph-to-character mapping and later raiseNSRangeException.This change:
Changelog:
[IOS] [FIXED] - Prevent crashes when text truncation splits a composed character sequence.
Test Plan:
yarn clang-format packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm packages/react-native/React/Tests/Text/RCTTextLayoutManagerTests.mm— passed.React-RCTFabric/Teststestspec in the local RNTester Podfile (not part of this change), then ran:Result: both
RCTTextLayoutManagerTeststests passed on an iPhone 17 Pro simulator running iOS 26.5. The targeted regression test was also verified to fail before the fix and pass afterward.