Prepare 12.3.1 maintenance release - #8565
Open
cknitt wants to merge 13 commits into
Open
Conversation
Backport the fix by tracking modules that actually recompiled, so stored warnings are replayed for dependents skipped after an earlier error. (cherry picked from commit 56d4ed5) Signed-off-by: Christoph Knittel <ck@cca.io>
* analysis: fix namespaced reference lookup * analysis: demonstrate incremental CMT lookup
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Adapted from 7f15521 for the 12.3.x Rewatch test layout.
* Preserve multibyte characters when wrapping long source lines in compiler code frames * Changelog
* Fix exponentiation right operand precedence Signed-off-by: Christoph Knittel <ck@cca.io> * Update changelog for exponentiation precedence fix Signed-off-by: Christoph Knittel <ck@cca.io> --------- Signed-off-by: Christoph Knittel <ck@cca.io>
Backport only the three type-system guards and focused regressions from 8fafaf9; omit the larger diagnostic-reporting refactor.
Backport only the independent bare labeled-arrow fix from 110534a; omit the broader external phantom-argument parser/printer rewrite.
Adapted from 5e23370 for the 12.x arity-marked parsetree. Signed-off-by: Christoph Knittel <ck@cca.io>
Lam_beta_reduce built the bindings for non-substitutable arguments by prepending during fold_left2 (reverse parameter order) and then wrapped the body with fold_right, making the first parameter's binding innermost - so the last argument was evaluated first. Fold left instead, so the first parameter's binding is outermost and arguments evaluate in call order. The reversed order was visible in checked-in output: bs_set_int_test.mjs evaluated setEqArray's second argument before its first. The new inline_arg_order_test fixture pins the order with recursive (hence non-substitutable) effectful arguments; its checked-in JS would show the regression directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Cristiano Calcagno <cristianoc@users.noreply.github.com> (cherry picked from commit 124bc4b)
Adapted from d0440c3 for the 12.x arity-marked typedtree. Signed-off-by: Christoph Knittel <ck@cca.io>
Adapted from d0440c3 for the 12.x typedtree. Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
codex/12.3.1
branch
2 times, most recently
from
August 21, 2026 08:05
3336296 to
f8aa648
Compare
cknitt
marked this pull request as ready for review
August 21, 2026 08:55
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8aa648561
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Christoph Knittel <ck@cca.io>
cristianoc
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the conservative ReScript 12.3.1 maintenance release from
maintenance/12.x.The fixes were backported chronologically and adapted where necessary to avoid pulling newer infrastructure or broad refactors:
=correctlyScope
This intentionally excludes larger or more invasive master changes, notably:
The goal is to fix concrete correctness and crash issues without increasing maintenance-release regression risk.
Validation
make testmake test-analysismake test-syntaxmake test-rewatchmake checkformatAll local checks pass, and CI is green across the full matrix.