Label y-axis units on stress-test CPU and inode panels - #69945
Open
charzl wants to merge 1 commit into
Open
Conversation
Fixes saltstack#69944 The CPU Usage panels (Master, Minion 1-3, API) use Grafana's percentunit, a 0-1 ratio where 1.0 == 1 full CPU core -- matching rate(container_cpu_usage_seconds_total[...]) semantics from cAdvisor. Without a label, a value like 1.2 is easy to misread as "1.2% of the host" rather than 1.2 CPU cores. The Minion Inodes panels use Grafana's "short" unit (a plain count) and also had no y-axis label. render_panels.py already special-cases bytes-family units to convert to MB and label the axis; this follows the same pattern for percentunit and short so every rendered panel states what its numbers mean.
Contributor
|
@charzl Target this to 3008.x please |
twangboy
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Fixes #69944.
Adds explicit y-axis labels for the two panel unit types in
tests/monitoring/render_panels.pythat were previously unlabeled:percentunit(a 0-1 ratio where1.0== 1 full CPU core), matchingrate(container_cpu_usage_seconds_total[...])from cAdvisor. Without a label, a value like1.2is easy to misread as "1.2% of the host" instead of 1.2 CPU cores.shortunit (a plain count frominodes_total - inodes_free) and also had no y-axis label.This follows the exact same pattern the file already uses for byte-family units (
ax.set_ylabel("MB")), just extended to the other two unit types actually present insalt_monitoring.json.What issues does this PR fix or reference
Fixes #69944
Merge requirements satisfied
salt_monitoring.jsonunit definitions (percentunitfor the CPU panels,shortfor the inode panels).If your PR is still in progress please convert it to a draft PR.