improvement(tables): raise the max column limit to 1000 - #6295
Conversation
Bumps TABLE_LIMITS.MAX_COLUMNS_PER_TABLE from 50 to 1000. Every validation site (schema validation, add-column, bulk add, workflow output columns, and the boundary contract) already derives from this constant.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Schema validation, API contracts ( Reviewed by Cursor Bugbot for commit 0d6550a. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR raises the shared maximum number of columns per table from 50 to 1000.
Confidence Score: 5/5The PR appears safe to merge, with the previously acknowledged wide-grid performance concern remaining non-blocking. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/constants.ts | Raises MAX_COLUMNS_PER_TABLE from 50 to 1000, expanding the shared validation boundary without changing its enforcement structure. |
Reviews (2): Last reviewed commit: "improvement(tables): raise the max colum..." | Re-trigger Greptile
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0d6550a. Configure here.
Summary
TABLE_LIMITS.MAX_COLUMNS_PER_TABLEfrom 50 to 1000MAX_ROW_SIZE_BYTES(400KB) and queries byMAX_QUERY_RESULT_BYTES; rows are stored as jsonb with no per-column index, so wider schemas add no DDL costType of Change
Testing
apps/sim/lib/table/__tests__/validation.test.ts— 68 passed (the max-columns case derives its fixture from the constant)bun run lintclean (9 pre-existing warnings inzoho-desk.test.ts, untouched here)check:boundaries,check:api-validation:strict,check:utils,check:zustand-v5,check:react-query,check:client-boundary,check:bare-icons,check:icon-paths,check:realtime-prune,skills:check,agent-stream-docs:checkChecklist