fix(combobox): keep the dropdown open while dragging its scrollbar - #6307
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The change tracks an in-progress pointer press that started inside No API or styling changes—behavior-only fix for Reviewed by Cursor Bugbot for commit f858231. Configure here. |
Greptile SummaryThis PR keeps editable combobox dropdowns open while users drag the native scrollbar and restores input focus when the pointer is released.
Confidence Score: 5/5The PR appears safe to merge. The previously reported documentation issue is fixed at the current HEAD, and no blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/combobox/combobox.tsx | Adds pointer-lifecycle handling for editable dropdown scrollbar drags and resolves the prior documentation-format feedback with TSDoc blocks. |
Reviews (2): Last reviewed commit: "improvement(combobox): move pointer-pres..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f858231. Configure here.
1 participant
Summary
onBlurstarts a 150ms timer that closes the dropdown unless focus is still inside it — option rows dodge that by preventing default on mousedown, but the list's native scrollbar doesn't, so pressing it parked focus on<body>and the dropdown dismissed itself.Combobox-backed picker (ChipCombobox,ChipSelect, credential/tool/file selectors) inherits the fix.Type of Change
Testing
Typecheck and lint pass. Not yet verified in the browser — worth a click-test on the Model dropdown (and a spot-check in Firefox/Safari, whose scrollbars behave differently).
Checklist