feat(workflows): generate short machine-nature names - #6906
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit f4d696e. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryGenerated workflow names now use a curated set of short, lowercase machine-nature pairs.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/stores/workflows/registry/utils.ts | Replaces the previous name generator with precomputed, length-bucketed machine-nature combinations and weighted random selection; no eligible follow-up issue remains. |
| apps/sim/stores/workflows/registry/utils.test.ts | Adds focused coverage for length weighting, candidate structure, curated exclusions, uniqueness, and expected representative names. |
Reviews (2): Last reviewed commit: "feat(workflows): generate short machine-..." | Re-trigger Greptile
717846f to
bea1ccc
Compare
492c4a3 to
9d2e473
Compare
9d2e473 to
7514f7f
Compare
Not addressing: the current stacked base passes |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7514f7f. Configure here.
7514f7f to
b638d99
Compare
Summary
Generated workflows now use short, lowercase machine-nature pairs instead of space-themed names. The curated 6,435-name space favors seven-letter word totals.
The deduplication and mutation-stability prerequisite landed in #6935. This PR now contains only the workflow-name generator and its focused coverage.
Type of Change
Testing
bun run --cwd apps/sim test -- stores/workflows/registry/utils.test.ts(2 tests passed)bun run check:api-validationbun run lint(passes with one pre-existing unused-suppression warning)Checklist
Screenshots/Videos
Not applicable; this changes generated text without changing layout or interaction.