Skip to content

feat(workflows): generate short machine-nature names - #6906

Merged
j15z merged 3 commits into
stagingfrom
feat/new-workflow-names
Aug 21, 2026
Merged

feat(workflows): generate short machine-nature names#6906
j15z merged 3 commits into
stagingfrom
feat/new-workflow-names

Conversation

@j15z

@j15z j15z commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Generated workflows now use short, lowercase machine-nature pairs instead of space-themed names. The curated 6,435-name space favors seven-letter word totals.

The deduplication and mutation-stability prerequisite landed in #6935. This PR now contains only the workflow-name generator and its focused coverage.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • bun run --cwd apps/sim test -- stores/workflows/registry/utils.test.ts (2 tests passed)
  • Exhaustively validates all 6,435 unique candidates, six-to-ten-letter totals, length weighting, and curated inclusions and exclusions
  • bun run check:api-validation
  • bun run lint (passes with one pre-existing unused-suppression warning)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not applicable; this changes generated text without changing layout or interaction.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 21, 2026 10:50pm

Request Review

@cursor

cursor Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Cosmetic default-name generation only; no auth, persistence, or API contract changes.

Overview
New workflows get short lowercase machine-nature names (e.g. bolt-ivy) instead of cosmos-themed adjective–noun pairs.

generateCreativeWorkflowName now picks from a precomputed pool of 3–5 letter word pairs totaling 6–10 letters, weighted toward seven-letter names then six. Tests lock in length weights, uniqueness, and excluded vocabulary.

Reviewed by Cursor Bugbot for commit f4d696e. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Generated workflow names now use a curated set of short, lowercase machine-nature pairs.

  • Replaces the space-themed adjective-noun vocabulary with names grouped by combined word length.
  • Weights selection toward seven-letter pairs, followed by six-letter pairs and progressively longer alternatives.
  • Adds focused tests for weighting, formatting, vocabulary exclusions, candidate uniqueness, and representative names.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/stores/workflows/registry/utils.ts Replaces the previous name generator with precomputed, length-bucketed machine-nature combinations and weighted random selection; no eligible follow-up issue remains.
apps/sim/stores/workflows/registry/utils.test.ts Adds focused coverage for length weighting, candidate structure, curated exclusions, uniqueness, and expected representative names.

Reviews (2): Last reviewed commit: "feat(workflows): generate short machine-..." | Re-trigger Greptile

Comment thread apps/sim/stores/workflows/registry/utils.ts
@j15z j15z changed the title feat(workflows): generate short machine-nature names feat(workflows): short machine-nature default names for new workflows Aug 20, 2026
@j15z
j15z force-pushed the feat/new-workflow-names branch from 717846f to bea1ccc Compare August 20, 2026 23:55
@j15z j15z changed the title feat(workflows): short machine-nature default names for new workflows feat(workflows): generate short machine-nature names Aug 20, 2026
@j15z
j15z changed the base branch from staging to fix/generated-workflow-name-deduplication August 21, 2026 17:50
@j15z
j15z force-pushed the feat/new-workflow-names branch from 492c4a3 to 9d2e473 Compare August 21, 2026 17:50
@j15z
j15z force-pushed the feat/new-workflow-names branch from 9d2e473 to 7514f7f Compare August 21, 2026 18:01
@j15z

j15z commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

An automatically generated duplicate causes workflow creation to return HTTP 409 because callers neither retry nor request deduplication.

Not addressing: the current stacked base passes deduplicate: true from both generated-name creation paths, and performCreateWorkflowTransition recomputes the name after workflow-name unique-index races for up to eight attempts. The generator may select an existing pair, but creation now succeeds with a server-selected suffix rather than returning a collision.

@j15z

j15z commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@j15z

j15z commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7514f7f. Configure here.

Base automatically changed from fix/generated-workflow-name-deduplication to staging August 21, 2026 22:29
@j15z
j15z force-pushed the feat/new-workflow-names branch from 7514f7f to b638d99 Compare August 21, 2026 22:29
@j15z
j15z merged commit cd935e8 into staging Aug 21, 2026
30 checks passed
@j15z
j15z deleted the feat/new-workflow-names branch August 21, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant