Skip to content

fix(tables): disable dispatcher task retries - #6963

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/table-dispatch
Aug 22, 2026
Merged

fix(tables): disable dispatcher task retries#6963
TheodoreSpeaks merged 1 commit into
stagingfrom
feat/table-dispatch

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the table dispatcher on small-2x
  • Remove non-idempotent task retries

Type of Change

  • Bug fix

Testing

  • bun run lint
  • Block registry and 32 repository audits
  • Table dispatcher configuration test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 22, 2026 2:31am

Request Review

@cursor

cursor Bot commented Aug 22, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Removes automatic retries for a long-lived dispatcher that previously OOM-killed and could leave dispatches stuck. Reliability depends on other cleanup rather than task retry.

Overview
Stops Trigger.dev from retrying table-run-dispatcher (including OOM escalation to medium-1x). The task still runs on small-2x.

Retries were treated as unsafe because the loop is not fully idempotent; the comment no longer claims a crash will resume from the DB cursor via a new attempt. The config test that pinned retry.outOfMemory / maxAttempts is removed.

Reviewed by Cursor Bugbot for commit f950ff1. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves the table-run dispatcher directly onto the medium-1x machine preset and intentionally removes task-level retries to avoid replaying non-idempotent work.

  • Updates the dispatcher machine preset from small-2x to medium-1x.
  • Removes automatic retry and out-of-memory escalation configuration.
  • Updates the configuration test to assert the new base machine.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The new machine preset is already supported and used elsewhere in the repository, while retry removal is an explicit design choice for non-idempotent dispatch work with stale-dispatch cleanup retained as the failure backstop.

Important Files Changed

Filename Overview
apps/sim/background/table-run-dispatcher.ts Runs dispatches on medium-1x and removes retries, relying on persisted window progress and stale-dispatch cleanup for failed attempts.
apps/sim/background/table-run-dispatcher.test.ts Updates the task configuration assertion for the new medium-1x preset and removes obsolete retry assertions.

Reviews (1): Last reviewed commit: "fix(tables): run dispatcher on medium ma..." | Re-trigger Greptile

@TheodoreSpeaks TheodoreSpeaks changed the title fix(tables): run dispatcher on medium machine fix(tables): disable dispatcher task retries Aug 22, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f950ff1. Configure here.

Comment thread apps/sim/background/table-run-dispatcher.ts
@TheodoreSpeaks
TheodoreSpeaks merged commit 818f714 into staging Aug 22, 2026
29 of 30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the feat/table-dispatch branch August 22, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant