Skip to content

fix(tables): omit ignored column diagnostics - #6970

Merged
j15z merged 1 commit into
stagingfrom
fix/table-block-omit-ignored-columns
Aug 22, 2026
Merged

fix(tables): omit ignored column diagnostics#6970
j15z merged 1 commit into
stagingfrom
fix/table-block-omit-ignored-columns

Conversation

@j15z

@j15z j15z commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Table query responses no longer expose ignoredColumns through the HTTP contract, Table tool, or Table block output. Missing column references are still skipped, valid column projection is unchanged, and skipped references remain available in server logs for diagnostics.

Related: #6954

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • bun run test -- 'app/api/table/[tableId]/query/route.test.ts' 'tools/table/query_rows_v2.test.ts' 'blocks/blocks/table_v2.test.ts' (40 tests passed)
  • bunx biome check on the seven edited source and test files
  • bun run tool-metadata:check
  • bun run check:api-validation

Review focus: confirm that stale column references remain non-fatal while ignoredColumns is absent from every public response surface.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not applicable. This follow-up changes response metadata only and does not alter the UI.

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 22, 2026 3:16am

Request Review

@cursor

cursor Bot commented Aug 22, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Response-shape cleanup only: query still skips unmatched columns, and diagnostics stay in server logs rather than the public API.

Overview
Removes ignoredColumns from the table query HTTP contract, Table block outputs, and generated tool metadata. Unknown or deleted column references are still skipped (not rejected); they are only logged server-side.

Query projection behavior is unchanged. Tests now assert the field is absent from the response rather than listing skipped refs.

Reviewed by Cursor Bugbot for commit 263cc8d. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR removes ignoredColumns from the table-query HTTP response and all corresponding tool and block output contracts while preserving non-fatal handling and server-side logging of stale column references.

  • Removes ignored-column diagnostics from the route contract and serialized response.
  • Aligns Table tool types, transformations, block outputs, and generated metadata.
  • Updates focused tests to verify that stale references remain non-fatal without exposing diagnostics.

Confidence Score: 5/5

The PR appears safe to merge, with all public response surfaces aligned and stale column references remaining non-fatal.

The route continues filtering valid columns, treats an empty matched-column set as an empty projection, and logs skipped references while the HTTP contract, tool transformation, types, block declaration, generated metadata, and tests consistently omit the diagnostic field.

Important Files Changed

Filename Overview
apps/sim/app/api/table/[tableId]/query/route.ts Stops returning ignored-column diagnostics while retaining projection behavior and server-side warning logs.
apps/sim/lib/api/contracts/tables.ts Updates the shared table-query response schema to match the reduced HTTP payload.
apps/sim/tools/table/query_rows_v2.ts Removes the diagnostic field from transformed and declared tool outputs.
apps/sim/tools/table/types.ts Aligns the typed Table Query v2 output with the new public response shape.
apps/sim/blocks/blocks/table_v2.ts Removes the obsolete output from the Table block’s downstream-reference schema.
apps/sim/tools/generated/tool-outputs.ts Regenerates built-in tool output metadata after the source declaration change.
apps/sim/app/api/table/[tableId]/query/route.test.ts Verifies mixed and wholly stale selections remain successful while diagnostics are omitted.
apps/sim/tools/table/query_rows_v2.test.ts Verifies the Table tool exposes only the supported query-result fields.

Reviews (1): Last reviewed commit: "fix(tables): omit ignored column diagnos..." | Re-trigger Greptile

@j15z
j15z merged commit b02fee1 into staging Aug 22, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/table-block-omit-ignored-columns branch August 22, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant