fix(tables): omit ignored column diagnostics - #6970
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Query projection behavior is unchanged. Tests now assert the field is absent from the response rather than listing skipped refs. Reviewed by Cursor Bugbot for commit 263cc8d. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR removes
Confidence Score: 5/5The PR appears safe to merge, with all public response surfaces aligned and stale column references remaining non-fatal. The route continues filtering valid columns, treats an empty matched-column set as an empty projection, and logs skipped references while the HTTP contract, tool transformation, types, block declaration, generated metadata, and tests consistently omit the diagnostic field.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/table/[tableId]/query/route.ts | Stops returning ignored-column diagnostics while retaining projection behavior and server-side warning logs. |
| apps/sim/lib/api/contracts/tables.ts | Updates the shared table-query response schema to match the reduced HTTP payload. |
| apps/sim/tools/table/query_rows_v2.ts | Removes the diagnostic field from transformed and declared tool outputs. |
| apps/sim/tools/table/types.ts | Aligns the typed Table Query v2 output with the new public response shape. |
| apps/sim/blocks/blocks/table_v2.ts | Removes the obsolete output from the Table block’s downstream-reference schema. |
| apps/sim/tools/generated/tool-outputs.ts | Regenerates built-in tool output metadata after the source declaration change. |
| apps/sim/app/api/table/[tableId]/query/route.test.ts | Verifies mixed and wholly stale selections remain successful while diagnostics are omitted. |
| apps/sim/tools/table/query_rows_v2.test.ts | Verifies the Table tool exposes only the supported query-result fields. |
Reviews (1): Last reviewed commit: "fix(tables): omit ignored column diagnos..." | Re-trigger Greptile
Summary
Table query responses no longer expose
ignoredColumnsthrough the HTTP contract, Table tool, or Table block output. Missing column references are still skipped, valid column projection is unchanged, and skipped references remain available in server logs for diagnostics.Related: #6954
Type of Change
Testing
bun run test -- 'app/api/table/[tableId]/query/route.test.ts' 'tools/table/query_rows_v2.test.ts' 'blocks/blocks/table_v2.test.ts'(40 tests passed)bunx biome checkon the seven edited source and test filesbun run tool-metadata:checkbun run check:api-validationReview focus: confirm that stale column references remain non-fatal while
ignoredColumnsis absent from every public response surface.Checklist
Screenshots/Videos
Not applicable. This follow-up changes response metadata only and does not alter the UI.