fix(types): include the data attribute on the connect_error event - #5544
Open
lazerg wants to merge 2 commits into
Open
fix(types): include the data attribute on the connect_error event#5544lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
connect_erroris typed as plainError, even though the client always attaches adataproperty to it (forwarded from theerr.dataset on the server-side middleware error). Accessingerr.datafrom a listener is a type error unless you cast it yourself.New behavior
connect_erroris now typed asError & { data?: any }, matching theExtendedErrorshape already used on the server side. The internal@ts-ignoreneeded to attach.datainonpacket()is gone too, since the variable is properly typed.Other information (e.g. related issues)
Fixes #5542