Skip to content

Avoid deprecated extractor in StatusHandler - #37037

Closed
sakshichitnis27 wants to merge 1 commit into
spring-projects:mainfrom
sakshichitnis27:fix/37010-status-handler-body-conversion
Closed

Avoid deprecated extractor in StatusHandler#37037
sakshichitnis27 wants to merge 1 commit into
spring-projects:mainfrom
sakshichitnis27:fix/37010-status-handler-body-conversion

Conversation

@sakshichitnis27

Copy link
Copy Markdown

Summary

  • Replace the deprecated HttpMessageConverterExtractor usage in StatusHandler with local response body conversion.
  • Preserve support for standard, generic, and smart message converters, including existing empty-body and error handling behavior.
  • Add focused tests for the replacement conversion paths.

Testing

  • ./gradlew :spring-web:test --tests org.springframework.web.client.StatusHandlerTests
  • ./gradlew :spring-web:check

Closes #37010

Closes spring-projectsgh-37010

Signed-off-by: sakshichitnis27 <sakshigchitnis27@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 10, 2026
@bclozel

bclozel commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks for the proposal @sakshichitnis27 - I went a different route in 51c4539 - instead of copying the now deprecated implementation, I extracted the relevant code from DefaultRestClient and shared it. This also aligns the behavior between proper body extraction and the status handler code path. Cheers!

@bclozel bclozel closed this Aug 5, 2026
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 5, 2026
@bclozel bclozel self-assigned this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using deprecated HttpMessageConverterExtractor in StatusHandler

3 participants