Skip to content

Fail CI when Gradle matrix generation fails - #11984

Merged
kiview merged 1 commit into
mainfrom
codex/fail-gradle-matrix-generation
Aug 26, 2026
Merged

Fail CI when Gradle matrix generation fails#11984
kiview merged 1 commit into
mainfrom
codex/fail-gradle-matrix-generation

Conversation

@kiview

@kiview kiview commented Aug 26, 2026

Copy link
Copy Markdown
Member

The dynamic Gradle matrix steps pipe Gradle output through jq. GitHub Actions runs these scripts with bash -e but without pipefail, so jq can return success after Gradle fails and leave the downstream matrix jobs skipped.

Enable pipefail for both filtered matrix-generation pipelines so Gradle failures fail the producer job. Successful empty matrices remain valid and continue to produce no matrix entries.

Summary by CodeRabbit

  • Bug Fixes
    • Improved build verification so failures in Gradle task discovery are correctly reported in continuous integration checks.

Enable pipefail for the filtered matrix-generation pipelines so a failing Gradle invocation cannot be masked by jq. Valid empty matrices remain supported.
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01c4c45f-62cf-43bf-be37-9f949eb3fc81

📥 Commits

Reviewing files that changed from the base of the PR and between 2f4475a and 9ad3b23.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow enables pipefail in regular and documentation-example Gradle task-discovery scripts. Piped command failures now propagate to the workflow.

Changes

CI failure propagation

Layer / File(s) Summary
Task-discovery pipeline handling
.github/workflows/ci.yml
The regular and documentation-example job-discovery scripts enable pipefail before running piped Gradle task-generation commands.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9ad3b

This localized workflow change makes Gradle matrix-generation failures fail CI as intended, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: eddumelendez, pioorg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: propagating Gradle matrix-generation failures to CI.
Description check ✅ Passed The description explains the affected pipelines, the failure behavior, the pipefail fix, and the handling of valid empty matrices. It satisfies the repository template's requirement for a brief chan…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the affected pipelines, the failure behavior, the pipefail fix, and the handling of valid empty matrices. It satisfies the repository template's requirement for a brief change description and context.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the github_actions Pull requests that update Github_actions code label Aug 26, 2026
@kiview
kiview marked this pull request as ready for review August 26, 2026 14:17
@kiview
kiview requested a review from a team as a code owner August 26, 2026 14:17
@kiview
kiview merged commit ca657f1 into main Aug 26, 2026
189 of 190 checks passed
@kiview
kiview deleted the codex/fail-gradle-matrix-generation branch August 26, 2026 14:44
@kiview kiview added this to the next milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code type/housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant