feat(webapp): name of the page in tab titles - #4517
Conversation
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (18)
WalkthroughAdded a shared 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kathiekiwi
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
changed the title
| it("adds the project and environment scope to an environment page", () => { | ||
| const title = renderTitle([rootRoute, orgRoute, { id: "routes/runs", meta: pageMeta("Runs") }]); | ||
|
|
||
| expect(title).toBe("Runs | Trigger.dev"); | ||
| }); |
There was a problem hiding this comment.
🔍 Test name and PR description claim project/environment scope that is not implemented
The test named "adds the project and environment scope to an environment page" asserts "Runs | Trigger.dev" — no project or environment appears in the title. The same claim is repeated in the PR description ("then the project and environment") and in the ENV_PARAMS comment. Only the organization scope is ever appended (scopeFromMatches in apps/webapp/app/utils/pageTitle.ts:70-75). Either the scope logic is missing project/env or the naming/description should be corrected so future readers don't assume the tested behaviour includes it.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Adds a shared
pageMeta()helper and 74 route declarations, so a title readsrun_abc | Runs | Trigger.dev— the specific thing first, then the page, then the project and environment. Org pages getTeam | Acme | Trigger.dev.Page names are unchanged; the project and environment scope is what's new. Three wording changes on purpose: the queue page now names the queue, the model page names the model, and entity pages carry their section.