Skip to content

Exclude the wp-compat false positive from the PHPStan config #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Aug 26, 2026
+12 −0
Merged

Exclude the wp-compat false positive from the PHPStan config #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
062abbb
Exclude the wp-compat false positive from the PHPStan config
claude Aug 26, 2026
6a2087d
Name the correct filter in the wp-compat rationale
claude Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,15 @@ parameters:
- identifier: missingType.property
- identifier: missingType.parameter
- identifier: missingType.return

# johnbillion/wp-compat checks every WordPress symbol against the WordPress 4.9
# baseline that wp-cli-tests configures, and reports anything newer.

# WordPress 6.0 only formalized the already documented `...$args` parameter of
# `apply_filters()` by adding it to the function signature. Additional arguments were
# collected through `func_get_args()` before that, so passing `$url` and
# `$oembed_args` to `pre_oembed_result` has always worked. The identifier already
# names one specific parameter of one specific function.
-
identifier: WPCompat.parameterNotAvailable.applyfilters.args
path: src/Fetch_Command.php